Skip to content

[stable25] Make images block nodes #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 9 commits into from
Nov 16, 2022
Merged

[stable25] Make images block nodes #3431

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16e509f
Add markdown-it-image-figures for treating images as block elements
mejo- Oct 19, 2022
26b958b
Make images block elements
mejo- Oct 19, 2022
4973f35
Special-treat commonmark tests with inline images
mejo- Oct 19, 2022
9e2e31e
Fix typo: 's/editor-midia-handler/editor-media-handler'
mejo- Oct 24, 2022
5bbbc31
Append two newlines to block images in toMarkdown
mejo- Oct 24, 2022
f0fe799
Unselect uploaded image in case it is the first element in editor
mejo- Oct 27, 2022
7f472eb
test: adjust markdown test to current behavior
max-nextcloud Nov 15, 2022
518099f
Use stable25 branch in cypress tests
mejo- Nov 15, 2022
0f568d3
Compile assets
nextcloud-command Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adjust markdown test to current behavior 
Right now we add an empty line after each image so it lives in its own paragraph.

This is not needed at the end of the file
and we should preserve the number of newlines instead (#3428).

But for now it should not block merging the block images pr #3282.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud @mejo-
max-nextcloud authored and mejo- committed Nov 15, 2022
commit 7f472eba5ee9ceccbc9bce13c8095fd1c624a92a
3 changes: 2 additions & 1 deletion src/tests/markdown.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ describe('Markdown though editor', () => {
expect(markdownThroughEditor('[bar\\\\]: /uri\n\n[bar\\\\]')).toBe('[bar\\\\](/uri)')
})
test('images', () => {
expect(markdownThroughEditor('![test](foo)')).toBe('![test](foo)')
expect(markdownThroughEditor('text ![test](foo) moretext')).toBe('text ![test](foo) moretext')
// regression introduced in #3282. To be fixed in #3428.
expect(markdownThroughEditor('![test](foo)')).toBe('![test](foo)\n\n')
})
test('special characters', () => {
expect(markdownThroughEditor('"\';&.-#><')).toBe('"\';&.-#><')
Expand Down