Fix mention uid autocomplete and keyboard handler in list nodes #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable25 |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
/compile |
marcelklehr
force-pushed
the
bugfix/mention
branch
from
776c8d4 to
b63bcff
Compare
Member
|
/compile |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
mejo-
force-pushed
the
bugfix/mention
branch
from
f377592 to
4544c06
Compare
|
The backport to stable25 failed. Please do this backport manually. |
Member
|
/backport bef86e9,daa717d39232998c83c25c2b19bf8b27c98e15e3 to stable25 |
1 task
Member
|
Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The mentions plugin was not catching the keyboard events when being triggered in a list/todo item, so I moved the registration of optional plugins for the editor after the default ones, which seems to fix the issue (as found in ueberdosis/tiptap#3339)
In addition the autocomplete endpoint for mentions now also filters by user id when iterating over the active user sessions.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)