Prevent file deletion when pressing Ctrl+Delete #3503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @jeremy238, Welcome! Thanks a lot for your pull request. I'll review it in a minute. If it looks good I'll rebase it and prepare everything for a merge as this can be somewhat tedious with text. I hope you don't mind. |
max-nextcloud
approved these changes
Dec 5, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good to me. I'll give it a try locally.
I might add a test to prevent breaking this again in the future.
Fix nextcloud#3391 Signed-off-by: jeremy238 <[email protected]>
Signed-off-by: jeremy238 <[email protected]>
max-nextcloud
force-pushed
the
patch-1
branch
from
c6f73cb to
fae0d2e
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Closed
Member
|
/backport df2b35c,fae0d2e to stable25 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
NC core was catching CTRL+delete event, that resulted in the deletion of the file. Now it's no longer forwarded to this.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)