Prevent dangling debounced extractHeadings function #3520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Tiptap heading extension registers a debounced extractHeadings function for onUpdate. If the editor gets removed but a debounced extractHeadings call is still pending, this leads to errors (which sometimes break tests). So let's check whether the editor is still alive and only call debounced extractHeadings in this case. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
mejo-
force-pushed
the
fix/dangling_debounce
branch
from
57a1fb4 to
3ba143d
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Collaborator
|
I wonder if this also applies to the other debounced functions we have. But then that's a different step / fix i guess. |
Collaborator
|
/backport 72a1c48 to stable25 |
Member
Author
|
/backport 72a1c48 to stable25 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Our Tiptap heading extension registers a debounced extractHeadings function for onUpdate. If the editor gets removed but a debounced extractHeadings call is still pending, this leads to errors (which sometimes break tests).
So let's track whether the editor is still alive and only call debounced extractHeadings in this case.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)