Skip to content

Replace "Saved" indicator with an icon #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 5 commits into from
Dec 16, 2022
Merged

Replace "Saved" indicator with an icon #3572

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f6f9c8
Replace "Saved" indicator with an icon
susnux Dec 14, 2022
6f30fbc
Unify status icon and session list with menu bar icons
susnux Dec 15, 2022
90cff34
Align active users button with close button above
susnux Dec 15, 2022
20825cf
Use saving indicator as used in the office app
susnux Dec 15, 2022
69fdf6d
Compile assets
nextcloud-command Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unify status icon and session list with menu bar icons 
* Set same size as menu bar entries: 44px
* Align icons vertically with menu bar
* Remove background and add background when hovering like menu bar

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Dec 16, 2022
commit 6f30fbcfe89812d907b02153b8534ee26f44f903
12 changes: 9 additions & 3 deletions src/components/Editor/SessionList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ export default {
</script>

<style scoped lang="scss">
.session-list {
height: 44px;
}
.avatar-list {
border: none;
background-color: var(--color-main-background);
Expand All @@ -166,10 +169,13 @@ export default {
}

.icon-more, .icon-group, .icon-settings-dark {
background-color: var(--color-background-dark);
width: 40px;
height: 40px;
width: 44px;
height: 44px;
margin: 0 6px 0 0;

&:hover {
background-color: var(--color-background-hover);
}
}
}

Expand Down
16 changes: 6 additions & 10 deletions src/components/Editor/Status.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ export default {
</script>

<style scoped lang="scss">

.text-editor__session-list {
display: flex;

Expand All @@ -146,23 +145,20 @@ export default {
}

.save-status {
background-color: var(--color-background-dark);
border-radius: 50%;
color: var(--color-text-lighter);
display: inline-flex;
justify-content: center;
padding: 0;
height: 40px;
width: 40px;
height: 44px;
width: 44px;

&.error {
border: 2px solid var(--color-error);
width: 36px;
height: 36px;
&:hover {
background-color: var(--color-background-hover);
}

&.saved {
color: var(--color-success)
&.error {
color: var(--color-error)
}
}

Expand Down