Skip to content

Editor frontend API #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 29 commits into from
Feb 1, 2023
Merged

Editor frontend API #3615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
61d6f8d
enh(editor): Wrap editor into a frontend API
juliusknorr Dec 29, 2022
8c6cd4d
enh(editor): Allow to setContent on the editor
juliusknorr Dec 29, 2022
988f99c
enh(Editor): Emit event on update
juliusknorr Dec 29, 2022
580bcf4
enh: Add event to load editor
juliusknorr Dec 29, 2022
2ee8534
fix(editor): Avoid errors when no parent component is present
juliusknorr Dec 29, 2022
dcaf534
feat: Add MarkdownContentEditor component
juliusknorr Dec 30, 2022
e914638
refactor: Make Wrapper component easier to reuse with default prop va…
juliusknorr Dec 30, 2022
d9ab846
refactor: Unify editor plugins for rich text editing in the RichText …
juliusknorr Dec 30, 2022
0c6345c
refactor: Allow to pass custom items/emit to mentions plugin
juliusknorr Dec 30, 2022
eb65c5f
chore: load script for direct editing outside of template
juliusknorr Dec 30, 2022
ccd5049
fix: Add fallback values for reading editors relative path
juliusknorr Dec 30, 2022
21adb2d
fix: Keep RichTextReader with previous extension set
juliusknorr Dec 30, 2022
ac03f67
chore: Update composer autoloader
juliusknorr Jan 19, 2023
e257f3d
fix(Wrapper): Avoid absolute positioning
juliusknorr Jan 27, 2023
160d64e
feat: Migrate to class based editor api and hook attachment/link/imag…
juliusknorr Jan 28, 2023
9a60337
fix: Only open image viewer on click to the actual image
juliusknorr Jan 28, 2023
78ee556
fix: Only render link previews if links start with http(s)
juliusknorr Jan 28, 2023
1d7cc11
fix: Move scroll container definition outside of core text components
juliusknorr Jan 28, 2023
e5b881d
docs: Add notes about the component integration to the readme
juliusknorr Jan 28, 2023
b78766b
fix: Implement onLoaded callback
juliusknorr Jan 28, 2023
1b76d99
fix: Set content for file editor
juliusknorr Feb 1, 2023
2da1f89
fix: Missing history plugin
juliusknorr Feb 1, 2023
9bc0880
fix(Menubar): Avoid negative offset on small screens
juliusknorr Jan 27, 2023
47b58c9
Expose focus command from createEditor
mejo- Feb 1, 2023
a0f9aa6
Fix imports and set webpackChunkName for async imports
mejo- Feb 1, 2023
4591c69
fix(MenuBar): Only preserve 100px for the right section
juliusknorr Feb 1, 2023
361a9d9
fix: Work around issue where numeric value is passed to prosemirror-m…
juliusknorr Feb 1, 2023
32f2cf8
Minor adjustments to README.md
mejo- Feb 1, 2023
49a898f
Compile assets
nextcloud-command Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Move scroll container definition outside of core text components 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Feb 1, 2023
commit 1d7cc110ea4a5f59cbde4f3daad30ac6401dab41
2 changes: 0 additions & 2 deletions src/components/Editor/MainContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ export default {
border-radius: var(--border-radius);
padding: 0;
position: relative;
overflow-y: auto;
overflow-x: hidden;
width: 100%;
}
</style>
1 change: 0 additions & 1 deletion src/components/Editor/Wrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ export default {
display: flex;
width: 100%;
height: 100%;
overflow: hidden;

&.show-color-annotations:deep(.author-annotation) {
padding-top: 2px;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Menu/MenuBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,9 @@ export default {
}

.text-menubar__slot {
// width: 100%;
justify-content: flex-end;
display: flex;
min-width: max(0px, min(200px, (100% - var(--text-editor-max-width)) / 2));
}

&.text-menubar--is-workspace {
Expand Down
5 changes: 5 additions & 0 deletions src/components/ViewerComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ export default {
},
}
</script>
<style lang="scss" scoped>
.text-editor {
overflow: scroll;
}
</style>
<style lang="scss">
@media only screen and (max-width: 512px) {
// on mobile, modal-container has top: 50px
Expand Down