Skip to content

Link picker #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 12 commits into from
Jan 30, 2023
Merged

Link picker #3700

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
603096b
refactor(suggestion): Refactor existing suggestions to reuse logic
juliusknorr Jan 26, 2023
1a39895
use vue-richtext helper functions to call the link picker
julien-nc Jan 26, 2023
7c72748
fix(Suggestion): Close link picker tippy if selected
juliusknorr Jan 26, 2023
4a49052
fix(LinkPicker): Show icons
juliusknorr Jan 26, 2023
9a05d97
fix(LinkPicker): Make sure that spaces after link paragraphs are ignored
juliusknorr Jan 26, 2023
26c2993
tests(Mentions): Fix cypress selector for mentions test
juliusknorr Jan 26, 2023
e02a2a1
adjust link picker suggestion style
julien-nc Jan 27, 2023
a116634
allow larger suggestion list
julien-nc Jan 27, 2023
6cda803
add menu action to open link picker
julien-nc Jan 27, 2023
932a2dc
chore(dependencies): Bump @nextcloud/vue-richtext
juliusknorr Jan 30, 2023
3ac47b9
fix: Properly destroy tippy on escape
juliusknorr Jan 30, 2023
82036c3
Compile assets
nextcloud-command Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests(Mentions): Fix cypress selector for mentions test 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Jan 30, 2023
commit 26c299328f534851283f55f46189500c47d3b693
4 changes: 2 additions & 2 deletions cypress/e2e/nodes/Mentions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('Test mentioning users', () => {

return cy.wait(`@${requestAlias}`)
.then(() => {
cy.get('.tippy-box .items').children().should(($children) => {
cy.get('.tippy-box .suggestion-list').children().should(($children) => {
const users = $children.map((i, el) => el.innerText).get()
expect(users.length).to.be.greaterThan(0)
expect(mention).to.be.oneOf(users)
Expand Down Expand Up @@ -78,7 +78,7 @@ describe('Test mentioning users', () => {

return cy.wait(`@${autocompleteReauestAlias}`)
.then(() => {
cy.get('.tippy-box .items').contains(mention).click()
cy.get('.tippy-box .suggestion-list').contains(mention).click()
cy.get('span.mention').contains(mention).should('be.visible')
})
})
Expand Down