Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 1, 2023

Otherwise we ship the Modal component twice in the bundles.

@cypress
Copy link

cypress bot commented Feb 1, 2023

Passing run #8569 ↗︎

0 132 0 0 Flakiness 0

Details:

chore(import): Avoid importing NcModal through other export
Project: Text Commit: 2c31138f74
Status: Passed Duration: 03:18 💡
Started: Feb 9, 2023 9:10 PM Ended: Feb 9, 2023 9:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

Screenshot 2023-02-02 at 08 20 46

@juliusknorr juliusknorr changed the title chore(import): Avoid importing NcModal throuhg other export chore(import): Avoid importing NcModal through+ other export Feb 2, 2023
@juliusknorr juliusknorr changed the title chore(import): Avoid importing NcModal through+ other export chore(import): Avoid importing NcModal through other export Feb 2, 2023
@juliusknorr
Copy link
Member Author

/rebase

@juliusknorr
Copy link
Member Author

/rebase

@juliusknorr
Copy link
Member Author

/compile amend /

@juliusknorr juliusknorr enabled auto-merge February 9, 2023 22:18
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit c31527c into main Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/import branch February 9, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants