fix: empty code blocks #3766
Merged
fix: empty code blocks #3766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/backport to stable25 |
1 flaky tests on run #8546 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloud
force-pushed
the
fix/3739-empty-codeblocks
branch
from
5acb525 to
733222b
Compare
Collaborator
Author
|
/compile |
max-nextcloud
requested review from
a team,
Raudius,
mejo- and
susnux
and removed request for
a team
max-nextcloud
requested review from
juliusknorr
and removed request for
Raudius
juliusknorr
approved these changes
Feb 8, 2023
Prosemirror and tiptap do not like empty text nodes. Leave out the entire text node instead. Fixes #3739. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/3739-empty-codeblocks
branch
from
d6acde8 to
8374999
Compare
Collaborator
Author
|
/backport 8374999 to stable25 |
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
1 task
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prosemirror and tiptap do not like empty text nodes. Leave out the entire text node instead.
Fixes #3739.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)