enh: store awareness messages separately #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
enh/separate-awareness-messages
branch
from
352eef4 to
8b668d2
Compare
1 flaky tests on run #8567 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliusknorr
reviewed
Feb 8, 2023
| let outbox | ||
| syncService.sendSteps(() => { | ||
| steps = this.#queue.map(s => encodeArrayBuffer(s)) | ||
| outbox = this.#queue |
Member
There was a problem hiding this comment.
When testing it seems that debouncing needs to be improved now for the push request, it seems on my test with two browsers the push is triggering every 200ms through the following stack trace even if the cursor positions do not change:
Collaborator
Author
There was a problem hiding this comment.
I suspect this is due to us replaying old awareness messages and creating an inconstent state.
I created #3785 to track it.
juliusknorr
reviewed
Feb 8, 2023
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/separate-awareness-messages
branch
from
8b668d2 to
88b6fa7
Compare
Collaborator
Author
|
/compile |
* `push` now expects an `awareness` parameter. * Closing the window closes the session which causes new sessions to receive the content of the doc rather than the state. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/separate-awareness-messages
branch
from
851bdc8 to
ffaf7bb
Compare
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
juliusknorr
approved these changes
Feb 9, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
👍
Also tested to collaborate a bit with @miaulalala and no collaboration issues encountered 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)