Skip to content

chore(deps): update dependency eslint-plugin-cypress to ^2.13.3 (stable26) #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 5 commits into from
May 3, 2023
Merged

chore(deps): update dependency eslint-plugin-cypress to ^2.13.3 (stable26) #4017

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e0d152
chore(deps): update dependency eslint-plugin-cypress to ^2.13.3
renovate[bot] May 3, 2023
f36f2eb
fix(cypress): to not chain from actions
max-nextcloud Apr 18, 2023
518323e
fix(cypress): Create callouts without leaving menu open.
max-nextcloud May 2, 2023
dcb5505
fix(cypress): avoid unnecessary `getSubmenuEnry` in workspace test
max-nextcloud May 3, 2023
06a7fd3
Compile assets
nextcloud-command May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(cypress): Create callouts without leaving menu open. 
Remove unnecessary `cy.getSubmenuEntry`
as it will open the parent menu.

This is a leftover from e9f54d0.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed May 3, 2023
commit 518323eace7611dd76b9c837a38d393c74f28706
19 changes: 9 additions & 10 deletions cypress/e2e/workspace.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,16 @@ describe('Workspace', function() {

// enable callout
cy.getSubmenuEntry('callouts', actionName).click()
cy.getSubmenuEntry('callouts', actionName).then(() => {
// check content
cy.getContent()
.find(`.callout.callout--${type}`)
.should('contain', 'Callout')

// disable
return cy.getSubmenuEntry('callouts', actionName)
.should('have.class', 'is-active')
.click()
})
// check content
cy.getContent()
.find(`.callout.callout--${type}`)
.should('contain', 'Callout')

// disable
cy.getSubmenuEntry('callouts', actionName)
.should('have.class', 'is-active')
.click()
})
})

Expand Down