Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

📝 Summary

Saving an empty document can happen from time to time but if it happens to often it may indicate some problem. Keep an eye on these without needing to log all debug things in text.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests - we don't test our logging.
  • Documentation is not required

Saving an empty document can happen from time to time
but if it happens to often it may indicate some problem.
Keep an eye on these without needing to log all debug things in text.

Signed-off-by: Max <[email protected]>
@max-nextcloud
Copy link
Collaborator Author

/backport to stable26

@cypress
Copy link

cypress bot commented Apr 20, 2023

2 failed and 1 flaky tests on run #9453 ↗︎

2 140 1 0 Flakiness 1

Details:

enh(log): use level warning for saving empty docs
Project: Text Commit: e2f8c22c56
Status: Failed Duration: 04:04 💡
Started: Apr 20, 2023 11:13 AM Ended: Apr 20, 2023 11:17 AM
Failed  cypress/e2e/attachments.spec.js • 2 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > See test files in the list and display hidden files Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Flakiness  cypress/e2e/sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants