Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 3, 2023

📝 Summary

Backport of #4071

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud changed the title Fix editing image description fails if enter isn't pressed [Backport] Fix editing image description fails if enter isn't pressed May 3, 2023
@cypress
Copy link

cypress bot commented May 3, 2023

1 flaky tests on run #9632 ↗︎

0 100 0 0 Flakiness 1

Details:

Merge 0db10bc into a0b8531...
Project: Text Commit: f0d13ff687 ℹ️
Status: Passed Duration: 05:55 💡
Started: May 3, 2023 6:41 PM Ended: May 3, 2023 6:47 PM
Flakiness  cypress/e2e/links.spec.js • 1 flaky test

View Output Video

Test Artifacts
test link marks > link preview > shows a link preview Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr changed the title [Backport] Fix editing image description fails if enter isn't pressed [stable25] Fix editing image description fails if enter isn't pressed May 3, 2023
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels May 3, 2023
@juliusknorr juliusknorr added this to the Nextcloud 25.0.7 milestone May 3, 2023
@max-nextcloud max-nextcloud force-pushed the fix/image-caption-update-stable25 branch from 0db10bc to 7530d17 Compare May 4, 2023 07:24
@max-nextcloud
Copy link
Collaborator

/compile amend /

Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/image-caption-update-stable25 branch from 3293f0e to 9705f36 Compare May 4, 2023 07:38
@max-nextcloud max-nextcloud merged commit 88a8c1b into stable25 May 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/image-caption-update-stable25 branch May 4, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants