Skip to content

[stable26] fix(Viewer): remove outdated fix from stable16. #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
May 4, 2023
Merged

[stable26] fix(Viewer): remove outdated fix from stable16. #4120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb2f81
fix(Viewer): remove outdated fix from stable16.
max-nextcloud May 4, 2023
a5771cd
Compile assets
nextcloud-command May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(Viewer): remove outdated fix from stable16. 
This broke the viewer resize and is not needed anymore.

In order to confirm this is not needed
i replaced the `beforeMount` handler with a `console.info` call
opened a text in the viewer and resized the window a few times.
The provided info only showed up once.
So the `ViewerComponent` was only mounted once as well.

Fixes #4099.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed May 4, 2023
commit eeb2f81105aec4e3953b975ae309aa3e95d51666
6 changes: 0 additions & 6 deletions src/components/ViewerComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ export default {
default: false,
},
},
beforeMount() {
// FIXME Dirty fix to avoid recreating the component on stable16
if (typeof this.$parent.$parent !== 'undefined' && this.$parent.$parent.onResize) {
window.removeEventListener('resize', this.$parent.$parent.onResize)
}
},
}
</script>
<style lang="scss" scoped>
Expand Down