-
Notifications
You must be signed in to change notification settings - Fork 109
fix: handle non markdown files in conflicts #4220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a82402 to
5b79fc4
Compare
2 flaky tests on run #10097 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
nodes/HardBreak.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Hard break support > Can create hard breaks with shift+enter |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
5b79fc4 to
104ff7c
Compare
848e005 to
7203c31
Compare
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, trusting in cypress for testing
7203c31 to
337dc3e
Compare
|
/backport to stable27 |
|
/backport to stable26 |
|
/compile |
6268f75 to
e33b368
Compare
e33b368 to
55d0771
Compare
|
/compile |
Do not parse non markdown files when resetting the content. Fixes #4205. Signed-off-by: Max <[email protected]>
Both the `.text-editor__main` and the `#read-only-editor` are not part of the Editor component that the style is scoped for. Signed-off-by: Max <[email protected]>
Text files are rendered as code blocks. Do not apply the prosemirror style to keep the background color. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
55d0771 to
36f21e6
Compare
|
/compile |
|
compile failures look like they might be related to the path setup on the runners. However it looked like this was a default github runner - so i don't quite understand what's going on here. |
Yeah. To be honest for me the workaround is to just restart them until the job is picked up by a not self-hosted runner 🙈 |
|
But the cypress failures look related to the PR, no? https://github.com/nextcloud/text/actions/runs/5214578471/jobs/9411036184?pr=4220#step:7:129 |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport cc601a7,8f5ca56d6beb2234746724e54d9c133b66736293,6a330e4a0c91b0274f53da2dac2d4825a9af1834,36f21e6ee2e2c338cb4e1a97218e16752f72954c to stable27 |
|
/backport cc601a7,8f5ca56d6beb2234746724e54d9c133b66736293,6a330e4a0c91b0274f53da2dac2d4825a9af1834,36f21e6ee2e2c338cb4e1a97218e16752f72954c to stable26 |
📝 Summary
Do not parse non markdown files when resetting the content.
Also add
CodeBlockextension in Reader so it renders the server version.Fixes #4205.
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)