Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented May 25, 2023

📝 Summary

Do not parse non markdown files when resetting the content.
Also add CodeBlock extension in Reader so it renders the server version.

Fixes #4205.

🚧 TODO

  • fix background of conflict view
  • tests

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch 3 times, most recently from 6a82402 to 5b79fc4 Compare May 25, 2023 15:38
@cypress
Copy link

cypress bot commented May 25, 2023

2 flaky tests on run #10097 ↗︎

0 146 1 0 Flakiness 2

Details:

fix: handle non markdown files in conflicts
Project: Text Commit: ce4775fb1f
Status: Passed Duration: 03:28 💡
Started: Jun 8, 2023 6:45 PM Ended: Jun 8, 2023 6:49 PM
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  nodes/HardBreak.spec.js • 1 flaky test

View Output Video

Test Artifacts
Hard break support > Can create hard breaks with shift+enter Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch from 5b79fc4 to 104ff7c Compare May 30, 2023 08:44
@max-nextcloud max-nextcloud marked this pull request as ready for review May 30, 2023 08:45
@max-nextcloud max-nextcloud requested a review from juliusknorr May 30, 2023 08:46
@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch 2 times, most recently from 848e005 to 7203c31 Compare May 30, 2023 08:47
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, trusting in cypress for testing

@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch from 7203c31 to 337dc3e Compare May 30, 2023 08:54
@max-nextcloud
Copy link
Collaborator Author

/backport to stable27

@max-nextcloud
Copy link
Collaborator Author

/backport to stable26

@max-nextcloud
Copy link
Collaborator Author

/compile

@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch 2 times, most recently from 6268f75 to e33b368 Compare June 6, 2023 06:22
@max-nextcloud max-nextcloud force-pushed the fix/4205-text-file-recovery branch from e33b368 to 55d0771 Compare June 8, 2023 10:22
@max-nextcloud
Copy link
Collaborator Author

/compile

Do not parse non markdown files when resetting the content.

Fixes #4205.

Signed-off-by: Max <[email protected]>
Both the `.text-editor__main` and the `#read-only-editor`
are not part of the Editor component that the style is scoped for.

Signed-off-by: Max <[email protected]>
Text files are rendered as code blocks.
Do not apply the prosemirror style to keep the background color.

Signed-off-by: Max <[email protected]>
@mejo- mejo- force-pushed the fix/4205-text-file-recovery branch from 55d0771 to 36f21e6 Compare June 8, 2023 18:32
@mejo-
Copy link
Member

mejo- commented Jun 8, 2023

/compile

@max-nextcloud
Copy link
Collaborator Author

compile failures look like they might be related to the path setup on the runners. However it looked like this was a default github runner - so i don't quite understand what's going on here.

@mejo-
Copy link
Member

mejo- commented Jun 8, 2023

compile failures look like they might be related to the path setup on the runners. However it looked like this was a default github runner - so i don't quite understand what's going on here.

Yeah. To be honest for me the workaround is to just restart them until the job is picked up by a not self-hosted runner 🙈

@mejo-
Copy link
Member

mejo- commented Jun 8, 2023

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 1b7928c into main Jun 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/4205-text-file-recovery branch June 8, 2023 19:29
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Jun 8, 2023

/backport cc601a7,8f5ca56d6beb2234746724e54d9c133b66736293,6a330e4a0c91b0274f53da2dac2d4825a9af1834,36f21e6ee2e2c338cb4e1a97218e16752f72954c to stable27

@mejo-
Copy link
Member

mejo- commented Jun 8, 2023

/backport cc601a7,8f5ca56d6beb2234746724e54d9c133b66736293,6a330e4a0c91b0274f53da2dac2d4825a9af1834,36f21e6ee2e2c338cb4e1a97218e16752f72954c to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.Txt Content deleted after restoring older Version an reopeninge with "Text"

5 participants