Skip to content

Prevent cumulative layout shift when rich workspace is loading #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mejo- wants to merge 2 commits into from
Closed

Prevent cumulative layout shift when rich workspace is loading #4254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
254a76d
Prevent cumulative layout shift when richworkspace is loading
mejo- Jun 7, 2023
748d58a
!fixup Prevent cumulative layout shift when richworkspace is loading
mejo- Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
!fixup Prevent cumulative layout shift when richworkspace is loading 
Instead of only increasing editor height with growing document length,
let's stick to a fixed height (150px) and use that one already while
loading the document.

The editor still increases when it gets focused.

Fixes: #2834
Fixes: #2803

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Jun 14, 2023
commit 748d58af5711b004a9e0970af4fe17a7c209c459
18 changes: 8 additions & 10 deletions src/views/RichWorkspace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export default {
z-index: 61;
position: relative;
&.creatable {
min-height: 100px;
min-height: 150px;
}
}

Expand Down Expand Up @@ -259,15 +259,19 @@ export default {
}

#rich-workspace.focus {
min-height: 25vh;
min-height: 150px;
max-height: 50vh;
}

#rich-workspace:not(.focus), #rich-workspace.icon-loading {
min-height: 25vh;
max-height: 25vh;
min-height: 150px;
max-height: 150px;
position: relative;
overflow: hidden;

:deep([data-text-el="menubar"]) {
display: none;
}
}

#rich-workspace:not(.focus):not(.icon-loading):not(.empty):after {
Expand All @@ -285,10 +289,4 @@ export default {
#rich-workspace.dark:not(.focus):not(.icon-loading):after {
background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0), var(--color-main-background));
}

@media only screen and (max-width: 1024px) {
#rich-workspace:not(.focus) {
max-height: 30vh;
}
}
</style>