Make use of session middleware in remaining controllers #4290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 flaky tests on run #10476 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
nodes/Mentions.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Test mentioning users > Type @ and see the user list |
Output
Screenshots
|
|
api/UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Member
Author
|
Need to check why the api test is flaky, could be either due to caching of the session or maybe the close request is not properly waited for |
juliusknorr
force-pushed
the
chore/noid/middleware-rest
branch
from
858fba0 to
d2c94f1
Compare
juliusknorr
force-pushed
the
chore/noid/middleware-rest
branch
from
d2c94f1 to
65fd06e
Compare
blizzz
approved these changes
Jun 23, 2023
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…leware Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
chore/noid/middleware-rest
branch
from
65fd06e to
84dd2d3
Compare
Member
|
/backport f5963e1 to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another larger backend changeset as a second part to #4266 to actually make use of it in the editing related controllers among a few cleanup tasks I did along the way.
Overall this should have some positive impact on performance as we reduce queries to fetch the session and document data to just one call in the middleware. Further way down in the the controller methods we just pass the objects around.
Let's see what cypress things about this.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)