Emit sync event after successful push to pick up syncing again

[juliusknorr]

• fix: Emit sync event after successful push to pick up syncing again
• tests(cypress): Refactor reconnect test to wait more reliably

🚧 TODO

• Needs fix(sync): Save even if versions match #4286

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

2 flaky tests on run #10379 ↗︎

0

147

1

0

2

Details:

Emit sync event after successful push to pick up syncing again
Project: Text	Commit: 72dfc69626
Status: Passed	Duration: 03:41 💡
Started: Jun 21, 2023 5:32 PM	Ended: Jun 21, 2023 5:35 PM

  sync.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Sync > recovers from a lost connection		Output Screenshots

  api/UsersApi.spec.js • 1 flaky test

View Output Video

Test		Artifacts
The user mention API > fetches users with valid session		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliusknorr]

Found two other reconnect bug when testing but those would be something for a different round:

• Open text
• Set to offline in network tab of browser console
• Click reconnect
• 🐛 It seems to show an error but request still happen and there is a continuous loading spinner

---

• Open text
• Delete the oc_text_session entry
• 🐛 See an empty editor

[juliusknorr]

Still need to figure out how to stabilize the save after reconnect

@max-nextcloud Do you have any suggestion or code pointer how we do that in other cypress tests? Might be worth to look into separating the save request soonish ;)

[max-nextcloud]

@max-nextcloud Do you have any suggestion or code pointer how we do that in other cypress tests? Might be worth to look into separating the save request soonish ;)

Looks like the save if versions match commit addressed this, right?

We have this in a bunch of places and my usual workaround was to wait for at least two syncs. Used to be so that first sync ensures steps by others are synced and second sync could then make sure we are up to date with our own steps.

I think if we fix the actual issue and maybe separate the save and sync requests we could get rid of a few of those waits.

[max-nextcloud]

I think if we fix the actual issue and maybe separate the save and sync requests we could get rid of a few of those waits.

The only example of that pattern i could find outside the directediting spec is unrelated:
https://github.com/nextcloud/text/blob/d32b251883057af456679de90322eeb1e716618a/cypress/e2e/nodes/FrontMatter.spec.js#L76C1-L77

So maybe we got rid of them already.

[juliusknorr]

To remove

[mejo-]

Thanks a lot for looking into this @juliushaertl! Code changes look sensible to me (apart from .only in the Cypress test).

[juliusknorr]

/compile

[juliusknorr]

/compile

[juliusknorr]

/compile