Y.js backend enhancements and debug helpers #4310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 failed and 4 flaky tests on run #12081 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
This comment was marked as outdated.
This comment was marked as outdated.
mejo-
approved these changes
Jun 28, 2023
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Nice! The code looks good to me, but I'd prefer if we could get a second review - especially of readVarUint() in lib/YjsMessage.php 🤓
juliusknorr
force-pushed
the
chore/yjs
branch
2 times, most recently
from
c70a37f to
d7d7810
Compare
Member
Author
|
Conflicts resolved, @max-nextcloud any chance you find some time? Not urgent but trying to get my open pr count down a bit 🙈 |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
chore/yjs
branch
from
d7d7810 to
2341059
Compare
max-nextcloud
approved these changes
Sep 13, 2023
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
The parsing of the base64 encoded messages and extraction of the first bits to get the types is nicely covered with tests. So I'm confident it's good as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
While looking into #4309 I thought it might be nicer to actually decode parts of the y.js message to perform relevant checks on it. This is now done in the YjsMessage class where so far only the relevant bits for extracting the message type is implemented. Upstream references are left in the code.
In addition I added a few logging parts in comments that might be useful in future debugging/development.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)