[stable25] fix: paste tables into document #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
changed the title
datenangebot
approved these changes
Jun 20, 2023
datenangebot
left a comment
datenangebot
left a comment
There was a problem hiding this comment.
Code looks good, but I don't have deeper knowledge here.
1 flaky tests on run #10412 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Content Sections > Heading anchors > Anchor scrolls into view |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <[email protected]> Signed-off-by: Jonas <[email protected]>
juliusknorr
force-pushed
the
backport/4285/stable25
branch
from
b90a95c to
e38b5b4
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #4285.
Fixes #2708.
Try to read the first table row as headings.
Pasting works via
insertContentwhile opening usessetContent. They use the schema in different ways.So we also need to make sure to test both for some corner cases.
setContentis fairly flexible in turning the input into a valid document structure.insertContenthowever fails to resolve structures that would require picking lower priority parent elements.Note: Some tests in src/tests/nodes/Table.spec.js
fail when using
insertContentinstead ofsetContent. Pasting the correponding html table is fixed never the less.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)