Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 24, 2023

This is a set of changes to cypress commands that should increase stability over CI runs. There still seem to be rare failures where some requests return a 401 on the backend which I'm continuing to follow debugging in #4350 however I think this would already be good to get in fast:

  • Move from axios usage to cy.request as I suspect that the axios promise was sometimes causing timing issues with requests
  • Use cy.selectFile instead of the 3rdparty helper
  • Rework recovery after lost connection test to await the session recreation
  • Avoid some extra navigation steps

@cypress
Copy link

cypress bot commented Jun 24, 2023

Passing run #10618 ↗︎

0 146 1 0 Flakiness 0

Details:

Rework cypress commands
Project: Text Commit: 33372da141
Status: Passed Duration: 06:42 💡
Started: Jun 26, 2023 10:57 AM Ended: Jun 26, 2023 11:04 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr force-pushed the ci/flaky-cypress branch 4 times, most recently from 1a6ea45 to 814d33b Compare June 25, 2023 16:44
@juliusknorr juliusknorr added tests If you write them we ♥ you 3. to review labels Jun 26, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Jun 26, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for looking into this @juliushaertl! All changes look good, just the first commit message seems to be wrong and a bit cluttered.

@juliusknorr
Copy link
Member Author

Cleaned up the commit messages :)

@juliusknorr juliusknorr merged commit d39c9b3 into main Jun 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the ci/flaky-cypress branch June 26, 2023 12:40
This was referenced Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review tests If you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants