Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip: test yjs chattiness
Signed-off-by: Max <[email protected]>
  • Loading branch information
max-nextcloud authored and mejo- committed Jul 11, 2023
commit c012aac34c0a47f9b3fae67878a5244a9ac12638
78 changes: 77 additions & 1 deletion cypress/e2e/api/SyncServiceProvider.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ describe('Sync service provider', function() {
})
}

it('creates the provider', function() {
it('syncs even when initial state was present', function() {
const source = new Doc()
const target = new Doc()
const sourceProvider = createProvider(source)
const targetProvider = createProvider(target)
const sourceMap = source.getMap()
const targetMap = target.getMap()
sourceMap.set('unrelated', 'value')
cy.intercept({ method: 'POST', url: '**/apps/text/session/push' })
.as('push')
cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' })
Expand All @@ -87,5 +88,80 @@ describe('Sync service provider', function() {
})
})

it('recovers from a dropped message', function() {
const source = new Doc()
const target = new Doc()
const sourceProvider = createProvider(source)
const targetProvider = createProvider(target)
const sourceMap = source.getMap()
const targetMap = target.getMap()
cy.intercept({ method: 'POST', url: '**/apps/text/session/push' })
.as('push')
cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' })
.as('sync')
cy.wait('@push')
cy.then(() => {
sourceMap.set('keyA', 'valueA')
expect(targetMap.get('keyA')).to.be.undefined
})
cy.wait('@sync')
cy.wait('@sync')
cy.wait(1000)
cy.then(() => {
expect(targetMap.get('keyA')).to.be.eq('valueA')
})
let count = 0
cy.intercept({ method: 'POST', url: '**/apps/text/session/push' }, req => {
if (count < 2) {
req.destroy()
req.alias = 'dead'
count += 1
} else {
req.continue()
req.alias = 'alive'
}
})
cy.then(() => {
sourceMap.set('keyB', 'valueB')
expect(targetMap.get('keyB')).to.be.undefined
})
cy.wait('@dead')
cy.wait('@sync')
cy.wait('@sync')
cy.wait(1000)
cy.then(() => {
expect(targetMap.get('keyB')).to.be.eq('valueB')
sourceProvider.destroy()
targetProvider.destroy()
})
})

it('is not too chatty', function() {
const source = new Doc()
const target = new Doc()
const sourceProvider = createProvider(source)
const targetProvider = createProvider(target)
const sourceMap = source.getMap()
const targetMap = target.getMap()
cy.intercept({ method: 'POST', url: '**/apps/text/session/push' })
.as('push')
cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' })
.as('sync')
cy.wait('@push')
cy.then(() => {
sourceMap.set('keyA', 'valueA')
expect(targetMap.get('keyA')).to.be.undefined
})
cy.wait(60000)
cy.then(() => {
expect(targetMap.get('keyA')).to.be.eq('valueA')
sourceProvider.destroy()
targetProvider.destroy()
})
// 2 clients push awareness updates every 15 seconds -> 2*5 = 10. Actual 15.
cy.get('@push.all').its('length').should('be.lessThan', 30)
// 2 clients sync fast first and then every 5 seconds -> 2*12 = 24. Actual 32.
cy.get('@sync.all').its('length').should('be.lessThan', 60)
})

})
2 changes: 1 addition & 1 deletion src/services/SyncServiceProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function createSyncServiceProvider({ ydoc, syncService, fileId, i
'ws://localhost:1234',
'file:' + fileId,
ydoc,
{ WebSocketPolyfill },
{ WebSocketPolyfill, disableBc: true },
)
websocketProvider.on('status', event => logger.debug('status', event))
return websocketProvider
Expand Down