Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 11, 2023

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jul 11, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Jul 11, 2023
@cypress
Copy link

cypress bot commented Jul 11, 2023

1 failed and 1 flaky tests on run #10997 ↗︎

1 147 2 0 Flakiness 1

Details:

fix: Encode individual parts of the dav url as uri components
Project: Text Commit: b2140b5be6
Status: Failed Duration: 03:52 💡
Started: Jul 12, 2023 8:35 AM Ended: Jul 12, 2023 8:39 AM
Failed  cypress/e2e/sync.spec.js • 1 failed test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  cypress/e2e/nodes/Mentions.spec.js • 1 flaky test

View Output Video

Test Artifacts
Test mentioning users > Type @ and see the user list Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like a charm 😊

@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 6e66858 into main Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/4156 branch July 12, 2023 08:40
@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/backport e5aa7e7 to stable27

@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/backport e5aa7e7 to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image attachment not shown when title of markdown file contains '#'

4 participants