Skip to content

Conversation

@juliusknorr
Copy link
Member

Backport of #4481

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jul 11, 2023
@juliusknorr juliusknorr requested review from blizzz and mejo- July 11, 2023 20:22
@juliusknorr juliusknorr modified the milestone: Nextcloud 25.0.9 Jul 11, 2023
@cypress
Copy link

cypress bot commented Jul 11, 2023

Passing run #10986 ↗︎

0 51 0 0 Flakiness 0

Details:

Merge caf90cf into cea1365...
Project: Text Commit: 5bd581a989 ℹ️
Status: Passed Duration: 03:02 💡
Started: Jul 12, 2023 7:01 AM Ended: Jul 12, 2023 7:04 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzz
Copy link
Member

blizzz commented Jul 11, 2023

There seems to be some compat issues with Guzzle https://github.com/nextcloud/text/actions/runs/5524518111/jobs/10076930887?pr=4490 on first sight… althought that looks unrealted. Still odd.

@juliusknorr
Copy link
Member Author

Definitely odd, I also see this locally, but the issues seem to be there already just considered as suppressed on the stable24 branch

composer run psalm -- --no-cache --threads=8 --show-info=true already shows them on the base branch. Probably a psalm bug, let me add the guzzle classes to suppress for this one.

@juliusknorr juliusknorr force-pushed the backport/4481/stable24 branch from 821ad4b to d91a841 Compare July 12, 2023 06:52
@juliusknorr
Copy link
Member Author

Damn, I accidentially pushed cea1365 to stable24 directly 🙈 Let me rebase this one

@juliusknorr juliusknorr force-pushed the backport/4481/stable24 branch from d91a841 to 822f918 Compare July 12, 2023 06:55
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 3b61d8d into stable24 Jul 12, 2023
@juliusknorr juliusknorr deleted the backport/4481/stable24 branch July 12, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants