Fix: clear pending autosync on close #4504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 failed and 1 flaky tests on run #11026 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
MenuBar.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Test the rich text editor menu bar > word count > empty file |
Output
Screenshots
|
|
cypress/e2e/api/UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
This would normally happen in the save call before closing. However if that call fails (for example due to a conflict) we still clear the pending autosync calls to prevent 403s. Fixes #4080. Signed-off-by: Max <[email protected]>
juliusknorr
force-pushed
the
fix/clear-pending-autosync-on-close
branch
from
5741cdc to
14d29b1
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
juliusknorr
approved these changes
Jul 12, 2023
Member
|
Let's backport for 27.1 |
Member
|
/backport to stable27 |
1 similar comment
Member
|
/backport to stable27 |
Member
|
/backport 14d29b1 to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This would normally happen in the save call before closing.
However if that call fails
(for example due to a conflict)
we still clear the pending autosync calls to prevent 403s.
Fixes #4080.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)