fix: Remember cursor position when autofocus on load

[juliusknorr]

📝 Summary

• Resolves: When opening a file cursor always jumps to end of content #4140

From being personally annoyed by it, this is a naive attempt to resolve #4140 to focus on the last cursor position. The position is remembered in the session storage per file and will be restored if present, otherwise we focus on the start (instead of the end).

Note that this may lead to cursor offsets if the document was changed in the meantime but so far I couldn't think of a proper way to get the position state relative to a node within the y.js doc and this should already improve the situation quite a bit. Even if the position is not exactly matching it seems more sane to focus close enough rather than to the end.

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[mejo-]

Very nice, works really well. Will have to adjust https://github.com/nextcloud/collectives/blob/main/src/components/Page/TextEditor.vue#L150 afterwards to make this work in Collectives.

Probably something we should backport to stable27 and stable26 because it fixes an annoying usability bug, right?

[mejo-]

nextcloud/collectives#795 is the corresponding PR for Collectives.

[cypress]

1 failed tests on run #11148 ↗︎

1

148

2

0

0

Details:

fix: Remember cursor position when autofocus on load
Project: Text	Commit: 23ba35c63d
Status: Failed	Duration: 03:32 💡
Started: Jul 17, 2023 5:02 PM	Ended: Jul 17, 2023 5:06 PM

  cypress/e2e/sync.spec.js • 1 failed test

View Output Video

Test		Artifacts
Sync > passes the doc content from one session to the next		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliusknorr]

/compile

[juliusknorr]

Probably something we should backport to stable27 and stable26 because it fixes an annoying usability bug, right?

Yes, would definitely do that.

[mejo-]

The position is remembered in the session storage per file and will be restored if present, otherwise we focus on the start (instead of the end).

After thinking more about it, I wonder whether it would be better to store this in localStorage instead of sessionStorage. sessionStorage seems a bit short-living to me (as someone who usually opens documents in new tabs and doesn't stick to one tab). The main problem I see with using localStorage is that it will get bloated with fileIds over time and I cannot think of a sane garbage collector mechanism. Maybe good to go with sessionStorage for now and see whether we want to change/improve it later on.

[juliusknorr]

Yes, the cleanup was the main reason why I picked session storage as it seemed more short living. I'd rather get this in now and then iteratively improve.

[mejo-]

/backport cd552ef to stable27

[mejo-]

/backport cd552ef to stable26

[juliusknorr]

Think I merged too fast, https://cloud.cypress.io/projects/hx9gqy/runs/11150/test-results/0a248360-1a30-4eae-89ac-64c7a3a593d4 seems related, I'll look into that tomorrow.