Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Jul 18, 2023

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before
image
image

🏑 After
image
image

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jul 18, 2023

Passing run #11460 β†—οΈŽ

0 149 2 0 Flakiness 0

Details:

feat: add component SkeletonLoading
Project: Text Commit: 26a401cf17
Status: Passed Duration: 04:18 πŸ’‘
Started: Aug 2, 2023 10:56 AM Ended: Aug 2, 2023 11:00 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member

I've added a quick screen recording for easier review by the designers with my proposed changes. @marcoambrosini could you have a look?

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer than the spinner :)
the only thing I would add is a small border radius to the rectangles, maybe 4px?

@juliusknorr
Copy link
Member

the only thing I would add is a small border radius to the rectangles, maybe 4px?

I'd keep this separate, if this shall be done then it would be good to structure this so that every app using skeleton loaders adjusts for the same target nextcloud version :)

@luka-nextcloud luka-nextcloud force-pushed the feature/add-skeleton-loading-component branch from b70d227 to c219eb1 Compare July 20, 2023 05:25
@luka-nextcloud luka-nextcloud force-pushed the feature/add-skeleton-loading-component branch from c219eb1 to c8b4cbe Compare July 28, 2023 14:31
@luka-nextcloud luka-nextcloud requested a review from mejo- July 28, 2023 14:34
@mejo- mejo- force-pushed the feature/add-skeleton-loading-component branch from c8b4cbe to 8807857 Compare July 31, 2023 20:29
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luka-nextcloud sorry for yet another round of feedback: both in src/components/Editor/Wrapper.vue and in src/views/RichWorkspace.vue there's leftovers in the CSS that refer to .icon-loading which is not used anymore. The ones in src/components/Editor/Wrapper.vue probably can be removed, the ones in src/view/RichWorkspace.vue look like they need to be updated to be active when this.loading is set, no?

@luka-nextcloud luka-nextcloud force-pushed the feature/add-skeleton-loading-component branch from 8807857 to b982efa Compare August 1, 2023 14:28
@luka-nextcloud luka-nextcloud requested a review from mejo- August 1, 2023 14:29
@mejo-
Copy link
Member

mejo- commented Aug 2, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 3ddd507 into main Aug 2, 2023
@mejo- mejo- deleted the feature/add-skeleton-loading-component branch August 2, 2023 11:17
@juliusknorr
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Aug 8, 2023

/backport b982efa to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use skeleton screen instead of loading spinner

6 participants