-
Notifications
You must be signed in to change notification settings - Fork 110
feat: add component SkeletonLoading #4545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Passing run #11460 βοΈDetails:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
I've added a quick screen recording for easier review by the designers with my proposed changes. @marcoambrosini could you have a look? |
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much nicer than the spinner :)
the only thing I would add is a small border radius to the rectangles, maybe 4px?
I'd keep this separate, if this shall be done then it would be good to structure this so that every app using skeleton loaders adjusts for the same target nextcloud version :) |
b70d227 to
c219eb1
Compare
c219eb1 to
c8b4cbe
Compare
c8b4cbe to
8807857
Compare
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luka-nextcloud sorry for yet another round of feedback: both in src/components/Editor/Wrapper.vue and in src/views/RichWorkspace.vue there's leftovers in the CSS that refer to .icon-loading which is not used anymore. The ones in src/components/Editor/Wrapper.vue probably can be removed, the ones in src/view/RichWorkspace.vue look like they need to be updated to be active when this.loading is set, no?
Signed-off-by: Luka Trovic <[email protected]>
8807857 to
b982efa
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
/backport to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport b982efa to stable27 |
π Summary
πΌοΈ Screenshots
ποΈ Before


π‘ After


π§ TODO
π Checklist
npm run lint/npm run stylelint/composer run cs:check)