fix: Use simple query and chunk in PHP to delete inactive sessions #4549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 1 flaky tests on run #11169 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
juliusknorr
force-pushed
the
bugfix/noid/mysql8
branch
from
dfc58a3 to
ba4145e
Compare
juliusknorr
changed the title
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
Member
Author
|
Cherry-picked to #4548 to validate the tests passing also on CI for MySQL 8 |
nickvergessen
approved these changes
Jul 19, 2023
mejo-
requested changes
Jul 19, 2023
reverts #4339 and #4539 except for the added tests and moves to plain PHP chunking to avoid issues with MySQL 8 Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/mysql8
branch
from
ba4145e to
0f8e441
Compare
mejo-
approved these changes
Jul 19, 2023
Member
Author
|
Failure known and unreated (fixed with #4550) |
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #4339 and #4539 except for the added tests and moves to plain PHP chunking to avoid issues with MySQL 8
Easiest to review in split mode https://github.com/nextcloud/text/pull/4549/files?diff=split
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)