Skip to content

fix(postgres): Use a unique index name #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Jul 20, 2023
Merged

fix(postgres): Use a unique index name #4553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(postgres): Use a unique index name 
ts_session is already used in Talk since Nextcloud 22.
Unluckily in Postgres index names have to be unique inside the database,
not only per table.

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 19, 2023
commit 0f2520c357bd7afb63bc46b295de51fc9a06fd42
2 changes: 1 addition & 1 deletion lib/Listeners/AddMissingIndicesListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ public function handle(Event $event): void {
return;
}

$event->addMissingIndex('text_steps', 'ts_session', ['session_id']);
$event->addMissingIndex('text_steps', 'textstep_session', ['session_id']);
}
}
2 changes: 1 addition & 1 deletion lib/Migration/Version010000Date20190617184535.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
$table->setPrimaryKey(['id']);
$table->addIndex(['document_id'], 'rd_steps_did_idx');
$table->addIndex(['version'], 'rd_steps_version_idx');
$table->addIndex(['session_id'], 'ts_session');
$table->addIndex(['session_id'], 'textstep_session');
}
return $schema;
}
Expand Down