Skip to content

[stable27] Allow opening files outside of the file system in viewer #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 6 commits into from
Aug 9, 2023
Merged

[stable27] Allow opening files outside of the file system in viewer #4658

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
becd1b1
Allow opening files outside of the file system in viewer
juliusknorr Aug 24, 2022
4eeff4e
fix: Avoid absolute positioning in viewer
juliusknorr Aug 2, 2023
6d62c07
fix: Keep viewer resize listener
juliusknorr Aug 4, 2023
3f7f6bc
fix(ViewerComponent): Only fetch source if `this.source` is set
mejo- Aug 8, 2023
5fd1995
fix: Properly handle viewer loading in collectives
juliusknorr Aug 9, 2023
6117bc3
chore(assets): Recompile assets
juliusknorr Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Keep viewer resize listener 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Aug 9, 2023
commit 6d62c07dc58cd2831c0090d9ee67b861621df04f
10 changes: 0 additions & 10 deletions src/components/ViewerComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,6 @@ export default {
source() {
this.loadFileContent()
},
active() {
this.loadFileContent()
},
},

beforeMount() {
// FIXME Dirty fix to avoid recreating the component on stable16
if (typeof this.$parent.$parent !== 'undefined' && this.$parent.$parent.onResize) {
window.removeEventListener('resize', this.$parent.$parent.onResize)
}
},

mounted() {
Expand Down