Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 14, 2023

Just reordering them as requested during the feature demo

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Aug 14, 2023

1 flaky tests on run #11686 ↗︎

0 149 2 0 Flakiness 1

Details:

fix: Sort regular smart picker options first
Project: Text Commit: 2abeb1f255
Status: Passed Duration: 09:01 💡
Started: Aug 14, 2023 2:18 PM Ended: Aug 14, 2023 2:27 PM
Flakiness  cypress/e2e/files.spec.js • 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle asciidoc as plaintext for now Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Aug 16, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Aug 16, 2023
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr juliusknorr force-pushed the fix/smartpicker-order branch from 2abeb1f to 24ac46b Compare August 18, 2023 07:58
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit e307c8b into main Aug 18, 2023
@juliusknorr juliusknorr deleted the fix/smartpicker-order branch August 18, 2023 08:38
@juliusknorr
Copy link
Member Author

/backport 24ac46b to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants