Skip to content

Lazy load text-viewer and text-files #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 3 commits into from
Nov 29, 2023
Merged

Lazy load text-viewer and text-files #4698

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8da8c40
Lazy load text-viewer and text-files
artonge Aug 24, 2023
8409b5a
fix: Lazy load viewer component
juliusknorr Nov 28, 2023
b9009dc
fix: Merge webpack splitChunks options
juliusknorr Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Merge webpack splitChunks options 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Nov 29, 2023
commit b9009dc9f6663eee2de470368f0ff2006b037e0c
23 changes: 5 additions & 18 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,12 @@ Object.assign(webpackConfig.output, {

webpackConfig.optimization.chunkIds = 'named'
webpackConfig.optimization.splitChunks.cacheGroups = {
defaultVendors: {
test(module) {
return module.resource && module.resource.includes(`${path.sep}node_modules${path.sep}`) &&
!module.resource.includes(`${path.sep}highlight.js${path.sep}`)
},
name: 'vendors',
}
mermaid: {
test: /[\\/]node_modules[\\/](mermaid)[\\/]/,
name: 'mermaid',
},
}
webpackConfig.optimization.splitChunks.minSize = 102400

// Fix Buffer issues
webpackConfig.plugins.push(new webpack.ProvidePlugin({
Expand All @@ -62,15 +60,4 @@ webpackRules.RULE_RAW_SVGS = {

webpackConfig.module.rules = Object.values(webpackRules)

webpackConfig.optimization.splitChunks.minSize = 102400

webpackConfig.optimization.splitChunks.cacheGroups = {
mermaid: {
test(module) {
return module.resource && module.resource.includes(`${path.sep}node_modules${path.sep}mermaid`)
},
name: 'mermaid',
},
}

module.exports = webpackConfig