Skip to content

fix(deps): update tiptap to ^2.1.6 (stable26) #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 3 commits into from
Aug 21, 2023
Merged

fix(deps): update tiptap to ^2.1.6 (stable26) #4717

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd54a74
fix(deps): update tiptap to ^2.1.6
renovate[bot] Aug 20, 2023
666db9f
fix: tiptap changed the shortcut for strikethrough
max-nextcloud Aug 19, 2023
290ba4e
chore(assets): Recompile assets
nextcloud-command Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: tiptap changed the shortcut for strikethrough 
It is ctrl-shift-s now.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Aug 21, 2023
commit 666db9fcb912c152a9bee46364e9112c565b61ce
2 changes: 1 addition & 1 deletion cypress/e2e/shortcuts.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('keyboard shortcuts', () => {
it('bold', () => testShortcut('{ctrl}b', 'strong'))
it('italic', () => testShortcut('{ctrl}i', 'em'))
it('underline', () => testShortcut('{ctrl}u', 'u'))
it('strikethrough', () => testShortcut('{ctrl}{shift}x', 's'))
it('strikethrough', () => testShortcut('{ctrl}{shift}s', 's'))
it('blockquote', () => testShortcut('{ctrl}{shift}b', 'blockquote'))
it('codeblock', () => testShortcut('{ctrl}{alt}c', 'pre'))
it('ordered-list', () => testShortcut('{ctrl}{shift}7', 'ol'))
Expand Down
2 changes: 1 addition & 1 deletion src/components/Menu/entries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export default [
{
key: 'strikethrough',
label: t('text', 'Strikethrough'),
keyChar: 'x',
keyChar: 's',
keyModifiers: [MODIFIERS.Mod, MODIFIERS.Shift],
icon: FormatStrikethrough,
isActive: 'strike',
Expand Down