[stable23] Avoid loading the image before the node view #4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]> Signed-off-by: nextcloud-command <[email protected]> Signed-off-by: Max <[email protected]>
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
max-nextcloud
changed the title
juliusknorr
approved these changes
Aug 21, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good 👍
Not covered by cypress tests it seems (we only have 14 at all in 23 🙈)
Didn't test, let me know if I shall give it a quick spin
Collaborator
Author
I tested locally myself. Should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Backport of #2675