Skip to content

Fix 403 on close #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mejo- merged 2 commits into from
Oct 30, 2023
Merged

Fix 403 on close #4824

mejo- merged 2 commits into from
Oct 30, 2023

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Sep 26, 2023

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@max-nextcloud max-nextcloud requested a review from mejo- September 26, 2023 08:48
mejo-
mejo- reviewed Sep 26, 2023
View reviewed changes
@max-nextcloud max-nextcloud requested a review from mejo- October 30, 2023 15:31
@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Oct 30, 2023

/backport to stable27

@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Oct 30, 2023

/backport to stable26

@max-nextcloud
fix(api): prevent sending requests with closed session.
d17bc9a 
Signed-off-by: Max <[email protected]>
@max-nextcloud
fix(api): send remaining steps before closing connection
d899714 
y.js will send a last awareness update when closing the websocket.
Try to get this out before closing the sync service connection.

Signed-off-by: Max <[email protected]>
@mejo- mejo- merged commit 8f14961 into main Oct 30, 2023
@mejo- mejo- deleted the fix/403-on-close branch October 30, 2023 21:19
@juliusknorr
Copy link
Member

juliusknorr commented Nov 2, 2023

/backport to stable27

@juliusknorr
Copy link
Member

juliusknorr commented Nov 2, 2023

/backport to stable26

@mejo-
Copy link
Member

mejo- commented Nov 7, 2023

/backport d17bc9a,d89971462e6233fa0d24be39bfa903c79f6cb6d2 to stable27

@mejo- mejo- mentioned this pull request Nov 7, 2023
Merged
@joshtrichards joshtrichards mentioned this pull request Dec 1, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@mejo- mejo- mejo- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Y.js fails to disconnect because session is already closed

4 participants

@max-nextcloud @juliusknorr @mejo-