Skip to content

enh(SyncService): Throw error on save failure #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Oct 11, 2023
Merged

enh(SyncService): Throw error on save failure #4836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enh(SyncService): Throw error on save failure 
This allows to detect errors when saving via the editor API.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo- @juliusknorr
mejo- authored and juliusknorr committed Oct 11, 2023
commit 24ada4f83f4f4ae3e2fa815133b644305ad863c3
1 change: 1 addition & 0 deletions src/services/SyncService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ class SyncService {
this.autosave.clear()
} catch (e) {
logger.error('Failed to save document.', { error: e })
throw e
}
}

Expand Down