[stable28] Refactor attachment loading #5053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
This format was only used from 03.01.2022 to 23.05.2022. Signed-off-by: Jonas <[email protected]>
…ment Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
`AttachmentResolver` only returns one candidate now. Signed-off-by: Jonas <[email protected]>
* Only open images from native attachments list * Only open images, non-image attachments are not supported anyway * Fix watcher for `startIndex` * Don't set computed property `currentImage` * Show error if image cannot be found in attachments Signed-off-by: Jonas <[email protected]>
* `getMetadata()` from AttachmentResolver class. * `isSupportedImage` logic from ImageView node. Was never used. * `hasPreview=true` logic from AttachmentResolver class. Signed-off-by: Jonas <[email protected]>
Required for AttachmentResolver to fetch list of attachments for the document. Signed-off-by: Jonas <[email protected]>
For all read-only attachments API endpoints, add support to authorize with user session or share token when no document session is available. Allows to get the attachments list and attachment files from MarkdownContentEditor.vue without a document session. Signed-off-by: Jonas <[email protected]>
We don't remember a legitimate reason why they would end up in a text document. Probably something that predate the attachments directory era. Signed-off-by: Jonas <[email protected]>
When viewer is available, not in use and supports the mimetype, and we're not in a public share, open the attachment in viewer. Otherwise, download the attachment. Fixes: #3849 Fixes: #4723 Fixes: #5030 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Also don't set any davPath at all in public share. We probably don't have DAV access there anyway. Signed-off-by: Jonas <[email protected]>
…ctoring Signed-off-by: Jonas <[email protected]>
Instead of just opening native image attachments, query the HTML document to get all loaded attachments (regardless whether native, via direct URL or via DAV) and list them. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5042