Skip to content

[stable27] fix(css): Fix print view in viewer and single-file share #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 12 commits into from
Nov 30, 2023
Merged

[stable27] fix(css): Fix print view in viewer and single-file share #5066

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ba111e9
fix(css): more specific selector for prosemirror print css
mejo- Nov 29, 2023
9233a33
fix(css): Add `page-break-*` properties along their `break-*` silblings
mejo- Nov 29, 2023
7afaef7
fix(css): No top+bottom margin+padding for editor in print view
mejo- Nov 29, 2023
e773dda
fix(css): Don't limit editor height in print view
mejo- Nov 29, 2023
9e51d53
test(cypress): Add test to visually compare print view
mejo- Nov 29, 2023
b1c03ad
fix(css): Fix print view in single-file shares
mejo- Nov 29, 2023
3ffe5a2
test(cypress): Add test to visually compare print view in single-file…
mejo- Nov 29, 2023
72d0f50
test(ci): Upload cypress snapshots on failure
mejo- Nov 29, 2023
a981f92
fix: Hide cursor in print output
juliusknorr Nov 30, 2023
b6762f5
test(cypress): Set caret-color to transparent before screenhots
mejo- Nov 30, 2023
a449c1e
test(cypress): Update screenshots of print view
mejo- Nov 30, 2023
88913b7
chore(assets): Recompile assets
nextcloud-command Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(cypress): Set caret-color to transparent before screenhots 
Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Nov 30, 2023
commit b6762f5d55eada61097697f6c0eb9cadc30e21e6
4 changes: 4 additions & 0 deletions cypress/e2e/print.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ describe('Open print.md and compare print view', function() {

cy.getEditor().should('be.visible')
cy.getContent()
// Ensure cursor is not displayed to prevent flaky tests (flashing input cursor)
.invoke('css', 'caret-color', 'transparent')
.get('h1:not(.hidden-visually)').should('contain', 'Print test')
.should('be.visible')

Expand All @@ -56,6 +58,8 @@ describe('Open print.md and compare print view', function() {
.then(() => {
cy.getEditor().should('be.visible')
cy.getContent()
// Ensure cursor is not displayed to prevent flaky tests (flashing input cursor)
.invoke('css', 'caret-color', 'transparent')
.get('h1:not(.hidden-visually)').should('contain', 'Print test')
.should('be.visible')

Expand Down