Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Dec 5, 2023

Manual backport of #4266

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just compared the two PRs and noticed this has not been backported: https://github.com/nextcloud/text/pull/4266/files#diff-0e3698f720b6901099c0893bf446ca1ac520cf3edddaa1f3f53abbb439f8585fR102

I assume that's to allow for older php versions, right?

@mejo-
Copy link
Member Author

mejo- commented Dec 5, 2023

Just compared the two PRs and noticed this has not been backported: https://github.com/nextcloud/text/pull/4266/files#diff-0e3698f720b6901099c0893bf446ca1ac520cf3edddaa1f3f53abbb439f8585fR102

I assume that's to allow for older php versions, right?

Nope, that already got backported by another manual backport with 716b313 and 19b3c75 😉

@mejo- mejo- requested a review from max-nextcloud December 5, 2023 13:46
@mejo-
Copy link
Member Author

mejo- commented Dec 5, 2023

/compile

@juliusknorr juliusknorr merged commit 27cf844 into stable27 Dec 5, 2023
@juliusknorr juliusknorr deleted the backport/4266/stable27 branch December 5, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants