Skip to content

[stable27] Refactor attachment loading #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 26 commits into from
Dec 6, 2023
Merged

[stable27] Refactor attachment loading #5087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a437b83
refactor(AttachmentService): Some code style cleanup
mejo- Oct 25, 2023
d331a36
chore(attachments): Remove support for obsolete `text://` format
mejo- Oct 31, 2023
0aa69d7
feat(attachments): API endpoint to get list of attachments for a docu…
mejo- Oct 25, 2023
a282b70
chore(attachments): Remove obsolete metadata API endpoint
mejo- Nov 15, 2023
29c79f8
feat(attachments): Use getAttachmentList API endpoint in resolver
mejo- Oct 31, 2023
a3ecdb1
fix(attachment): Remove candidate logic from ImageView node
mejo- Nov 15, 2023
af29e57
fix(attachments): Fix some issues with the showimage modal
mejo- Nov 21, 2023
a6fcc87
chore(attachments): Remove obsolete code
mejo- Nov 21, 2023
95ef57d
feat(editor): Allow to pass fileId to MarkdownContentEditor
mejo- Nov 21, 2023
969b85c
feat(attachments): Allow to get attachments without document session
mejo- Nov 22, 2023
4441e7a
chore(attachments): Remove special-handling for preview URLs
mejo- Nov 22, 2023
3703ea1
fix(attachments): Open non-image attachments in viewer or download
mejo- Nov 22, 2023
c2a7fea
fix(AttachmentController): Set fileName of returned attachments
mejo- Nov 27, 2023
95c6734
chore(composer): Update autoloader maps
mejo- Nov 27, 2023
e2b2c16
fix(attachments): Fix encoding of attachment URI component
mejo- Nov 27, 2023
463b55f
test(cy): Test to open image in modal and download attachment
mejo- Nov 28, 2023
cd51248
chore(middleware): Rename to RequireDocumentSessionOrUserOrShareToken
mejo- Nov 28, 2023
d135f9d
fix(attachments): use `getRelativePath` from userFolder for `davPath`
mejo- Nov 28, 2023
112e399
test(AttachmentResolver): Refactor jest tests after parent class refa…
mejo- Nov 28, 2023
cf30cde
fix(attachments): Show all loaded images in ShowImageModal
mejo- Nov 28, 2023
99ac897
fix(SessionMiddleware): Check if user/share have access to document
mejo- Nov 29, 2023
64b7639
fix(AttachmentResolver): Require either fileId or session
mejo- Nov 29, 2023
a4cafdc
reactor(ImageView): Simplify attachmentType/isMediaAttachment logic
mejo- Nov 29, 2023
febbd11
fix(deps): Update to cypress 13
mejo- Dec 5, 2023
70b5a89
chore(deps): Move `cypress-visual-regression` to dev dependencies
mejo- Dec 5, 2023
8b67f07
chore(assets): Recompile assets
nextcloud-command Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(deps): Update to cypress 13 
Required for the file attachment download test to succeed.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Dec 5, 2023
commit febbd111523e2106e2ee26ff7bedde0207246f73
128 changes: 72 additions & 56 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@
},
"devDependencies": {
"@cypress/browserify-preprocessor": "^3.0.2",
"@cypress/webpack-preprocessor": "^5.17.1",
"@cypress/webpack-preprocessor": "^6.0.0",
"@nextcloud/babel-config": "^1.0.0",
"@nextcloud/browserslist-config": "^2.3.0",
"@nextcloud/cypress": "^1.0.0-beta.2",
"@nextcloud/cypress": "^1.0.0-beta.6",
"@nextcloud/dialogs": "^4.2.2",
"@nextcloud/eslint-config": "^8.3.0",
"@nextcloud/stylelint-config": "^2.3.1",
Expand All @@ -126,7 +126,7 @@
"@vue/test-utils": "^1.3.0 <2",
"@vue/vue2-jest": "^29.2.6",
"@vueuse/core": "^10.6.1",
"cypress": "^12.17.4",
"cypress": "^13.6.0",
"eslint-plugin-cypress": "^2.15.1",
"identity-obj-proxy": "^3.0.0",
"jest": "^29.7.0",
Expand Down