Skip to content

feat(editor): Enable gapcursor, allows to put cursor between images #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 3 commits into from
Dec 6, 2023
Merged

feat(editor): Enable gapcursor, allows to put cursor between images #5095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3762d25
style(RichText): Order imports alphabetically
mejo- Dec 6, 2023
0765273
feat(editor): Enable gapcursor, allows to put cursor between images
mejo- Dec 6, 2023
4f7bc37
fix(MediaHandler): Remove workaround to add newline between images
mejo- Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(MediaHandler): Remove workaround to add newline between images 
Fixes: #3427

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Dec 6, 2023
commit 4f7bc371f9186e0e85196411a2d04ee4d4e7e5c4
6 changes: 0 additions & 6 deletions src/components/Editor/MediaHandler.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,8 @@ export default {
// subsequent editor inserts (see tiptap#3355). So unselect the image by placing
// the cursor at the end of the selection.
this.$editor.commands.focus(selection.to)
} else {
// Place the cursor after the inserted image node
this.$editor.commands.focus(selection.to + 2)
}

// Insert a newline to allow placing the cursor in between subsequent images
this.$editor.chain().insertContent('<br />').focus().run()

// Scroll image into view
this.$editor.commands.scrollIntoView()

Expand Down