Cypress: Improve request token handling, attachments test #5129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `this.requesttoken` rather than `cy.get(@requesttoken)` to use the same value rather than re-evaluating the query. * After visit `this.requesttoken` will be set. No need to attempt to load the token from the window if it is not. * Use a simple `if` statement instead of `cypress-if`. * This also cleans up the cypress logs significantly. Signed-off-by: Max <[email protected]>
* call `cy.showHiddenfiles()` before loading the page. * Clear `requesttoken` in `cy.login()`. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Fix the warning in CI. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
test/better-cy-logs
branch
from
6996158 to
2263c8f
Compare
mejo-
approved these changes
Dec 13, 2023
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Changes look sensible, and great to get rid of cypress-if again 🎉
Collaborator
Author
|
/backport to stable28 |
Member
|
/backport to stable28 |
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Make sure to reuse the same token as long as its valid and clear it when it does not match the current session anymore (
login,visit).Also make the cypress logs less verbose and easier to parse.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)