[stable27] preserve websocket provider queue during reconnects #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a network disconnect Yjs-websocket notices missing awareness messages and closes the connection. In this case the remaining steps can also not be send out and the request fails. Preserve the queue so we can use it once the network is back up. Signed-off-by: Max <[email protected]>
When yjs does not receive awareness updates it will close and reopen the websocket. Keep the content of the queue, i.e. the outgoing steps so they can be send out once the connection is back. Signed-off-by: Max <[email protected]>
Change the content of `queue` with `queue.splice` rather than setting `queue` to another array. Signed-off-by: Max <[email protected]>
Also add a unit test for the websocket polyfill Signed-off-by: Max <[email protected]>
avoids the old provider leaking error events. Signed-off-by: Max <[email protected]>
Collaborator
Author
|
/backport to stable26 |
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Collaborator
Author
|
We will need to investigate the sync spec failure in cypress. That might be related. |
Member
|
I know one is also sometimes failing on other branches, but would be good to check, yes :) |
Collaborator
Author
|
Collaborator
Author
|
The failures look exactly the same as before. Opened #5154 to investigate further. Let's move on with this. |
juliusknorr
approved these changes
Dec 21, 2023
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Member
|
@max-nextcloud Can you check the backport to 26? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary