cleanup(SyncService): this.sessions and this.steps #5188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both were kept up to date but never used as far as i can tell. Signed-off-by: Max <[email protected]>
juliusknorr
approved these changes
Jan 2, 2024
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Good catch, also couldn't see any usage when double checking.
Member
|
@max-nextcloud Labels and milestone would be good to set. That way it is much easier to collect changes for either a changelog or aggregating what's new on releases. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Both were kept up to date but never used as far as i can tell.
Extracted from #3799
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)