fix: Prioritize un-collapsible menubar entries for mobile and aggregate children in the hidden entries #5226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
JuliaKirschenheuter,
max-nextcloud and
mejo-
mejo-
approved these changes
Jan 10, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Didn't test the code, but looks sensible to me. Only one comment.
…te children in the hidden entries Co-authored-by: Jonas <[email protected]> Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/5220
branch
from
8e6a07f to
b38ea59
Compare
Member
Author
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5220
There are some menubar entires that cannot be collapsed in the hidden entries list as they trigger another popover which comes with too much complexity to implement a nested popover now. However with 320px we have enough space to show all of them.
For others (like callout actions) where the menu is just a list of simple action buttons we can just merge them into the overflow menu.
This ensures that any action is usable on all screen sizes >= 320px.