Skip to content

fix: Only unpause focus traps that we paused ourselves #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Feb 1, 2024
Merged

fix: Only unpause focus traps that we paused ourselves #5327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Only unpause focus traps that we paused ourselves 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Feb 1, 2024
commit c22d700a37654d5e7ad74397b9c33307ea56d991
8 changes: 7 additions & 1 deletion src/extensions/FocusTrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Extension } from '@tiptap/core'

let ownPaused = false

const toggleFocusTrap = ({ editor }) => {
const trapStack = window._nc_focus_trap ?? []
const activeTrap = trapStack[trapStack.length - 1]
Expand All @@ -10,8 +12,12 @@ const toggleFocusTrap = ({ editor }) => {

if (possibleEditorTabCommand) {
activeTrap?.pause()
ownPaused = true
} else {
activeTrap?.unpause()
if (ownPaused) {
ownPaused = false
activeTrap?.unpause()
}
}
}

Expand Down