Skip to content

[stable28] fix(menubar): menubar and table menus a11y #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 12 commits into from
Feb 1, 2024
Merged

[stable28] fix(menubar): menubar and table menus a11y #5330

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
52df535
fix: apply a11y attrs for session list trigger
ShGKme Jan 23, 2024
564e282
fix(menubar): remove unneeded roles `menu`, `menuitem`
ShGKme Jan 9, 2024
8085f07
fix(menubar): remove incorrect `aria-haspopup`
ShGKme Jan 31, 2024
2c0434b
fix(menubar): remove incorrect `aria-activedescendant`
ShGKme Jan 12, 2024
0ba5204
fix(table): replace InlineActionsContainer by NcActionButtonGroup
ShGKme Jan 10, 2024
cfcf05a
fix(table): make text align buttons radio
ShGKme Jan 31, 2024
55b44fc
fix(menubar): replace aria-pressed with text description in action list
ShGKme Jan 11, 2024
d4b7975
refactor: implement ActionSingle via template instead of render-function
ShGKme Jan 23, 2024
82f6d12
fix(menubar): set correct type for buttons instead of aria-selected
ShGKme Jan 10, 2024
e527752
fix(menubar): separate NcActionButton from ActionSingle
ShGKme Jan 30, 2024
42741b8
fix(menubar): add separator between radio groups
ShGKme Jan 30, 2024
633c543
fix(menubar): name ActionFormattingHelp as NcActionButton to support …
ShGKme Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: apply a11y attrs for session list trigger 
- Migrate from deprecated slot syntax
- Use a11y attrs from `NcPopover` on a custom button

Signed-off-by: Grigorii K. Shartsev <[email protected]>
  • Loading branch information
@ShGKme @backportbot
ShGKme authored and backportbot[bot] committed Feb 1, 2024
commit 52df53599a0ce32d11a8d65966cffc7a82e85e86
25 changes: 14 additions & 11 deletions src/components/Editor/SessionList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,20 @@

<template>
<NcPopover class="session-list" placement="bottom">
<div slot="trigger">
<button :title="label"
:aria-label="label"
class="avatar-list">
<div class="avatardiv icon-group" />
<AvatarWrapper v-for="session in sessionsVisible"
:key="session.id"
:session="session"
:size="40" />
</button>
</div>
<template #trigger="{ attrs }">
<div>
<button :title="label"
:aria-label="label"
class="avatar-list"
v-bind="attrs">
<div class="avatardiv icon-group" />
<AvatarWrapper v-for="session in sessionsVisible"
:key="session.id"
:session="session"
:size="40" />
</button>
</div>
</template>
<template #default>
<div class="session-menu">
<slot name="lastSaved" />
Expand Down