Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • hard to test:
    • somewhat complicated to create the state
    • hard to detect it's actually broken.
  • Documentation is not required

@max-nextcloud max-nextcloud added this to the Nextcloud 29 milestone Mar 11, 2024
@max-nextcloud max-nextcloud requested a review from mejo- March 11, 2024 14:35
@max-nextcloud
Copy link
Collaborator Author

/backport to stable28

@max-nextcloud
Copy link
Collaborator Author

/backport to stable27

@max-nextcloud
Copy link
Collaborator Author

/backport to stable26

@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Mar 11, 2024

After this fix the broken tables below are removed when opening the session again.

@mejo- mejo- force-pushed the fix/images-in-tables branch from fa7b804 to f7d50b8 Compare March 12, 2024 15:03
@max-nextcloud max-nextcloud merged commit 4206566 into main Mar 12, 2024
@max-nextcloud max-nextcloud deleted the fix/images-in-tables branch March 12, 2024 15:46
@backportbot
Copy link

backportbot bot commented Mar 12, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/5461/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7d50b89

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5461/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Mar 12, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/5461/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7d50b89

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5461/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken table state

4 participants