fix: Avoid race condition that may initialize a document twice on the clients #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clients Signed-off-by: Julius Härtl <[email protected]>
Closed
max-nextcloud
approved these changes
Mar 13, 2024
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix may help with duplicate content of documents.
While staring at code and reading yjs/yjs-demos#16 I noticed we may have a race condition where two browsers would attempt to create a new document, while that is catched the session receiving the unique constraint exception would still continue with the freshSession value set to true and handing over the file content and using that to initialize the document again locally.