Skip to content

[stable27] fix(backend): Accept pushs with only step1 messages by read-only clients #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Mar 13, 2024
Merged

[stable27] fix(backend): Accept pushs with only step1 messages by read-only clients #5472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(backend): Accept pushs with only step1 messages by read-only clients 
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Mar 13, 2024
commit ba7447f2e6e3acfb5c332e391521e240a37cb4e1
11 changes: 3 additions & 8 deletions lib/Service/ApiService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ public function close($documentId, $sessionId, $sessionToken): DataResponse {

/**
* @throws NotFoundException
* @throws DoesNotExistException
*/
public function push(Session $session, Document $document, $version, $steps, $awareness, $token = null): DataResponse {
try {
Expand All @@ -196,16 +195,12 @@ public function push(Session $session, Document $document, $version, $steps, $aw
if (empty($steps)) {
return new DataResponse([]);
}
$file = $this->documentService->getFileForSession($session, $token);
if ($this->documentService->isReadOnly($file, $token)) {
return new DataResponse([], 403);
}
try {
$result = $this->documentService->addStep($document, $session, $steps, $version);
$result = $this->documentService->addStep($document, $session, $steps, $version, $token);
} catch (InvalidArgumentException $e) {
return new DataResponse($e->getMessage(), 422);
} catch (DoesNotExistException $e) {
// Session was removed in the meantime. #3875
} catch (DoesNotExistException|NotPermittedException) {
// Either no write access or session was removed in the meantime (#3875).
return new DataResponse([], 403);
}
return new DataResponse($result);
Expand Down
10 changes: 8 additions & 2 deletions lib/Service/DocumentService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,14 @@ public function writeDocumentState(int $documentId, string $content): void {
* @param $sessionId
* @param $steps
* @param $version
* @param $shareToken
* @return array
* @throws DoesNotExistException
* @throws InvalidArgumentException
* @throws NotFoundException
* @throws NotPermittedException
* @throws DoesNotExistException
*/
public function addStep(Document $document, Session $session, $steps, $version): array {
public function addStep(Document $document, Session $session, $steps, $version, $shareToken): array {
$sessionId = $session->getId();
$documentId = $session->getDocumentId();
$stepsToInsert = [];
Expand All @@ -233,6 +236,9 @@ public function addStep(Document $document, Session $session, $steps, $version):
}
}
if (sizeof($stepsToInsert) > 0) {
if ($this->isReadOnly($this->getFileForSession($session, $shareToken), $shareToken)) {
throw new NotPermittedException('Read-only client tries to push steps with changes');
}
$newVersion = $this->insertSteps($document, $session, $stepsToInsert, $version);
}
// If there were any queries in the steps send the entire history
Expand Down